deprecate packages sets, retry, github; release v0.14.0#171
deprecate packages sets, retry, github; release v0.14.0#171marco-m-pix4d merged 2 commits intomasterfrom
Conversation
marco-m-pix4d
requested review from
SpectreVert,
aliculPix4D,
iAmoric and
odormond
| // See the README and CONTRIBUTING files for additional information, caveats about GitHub | ||
| // API and imposed limits, and reference to official documentation. | ||
| // | ||
| // Deprecated: Package github is replaced by github.com/Pix4D/go-kit/github. |
There was a problem hiding this comment.
Go is really a well-designed tool :)
There was a problem hiding this comment.
Yes. It is so pleasant to notice how much care went into it.
:) |
So how to you plan to merge this PR if the CI fails ? 😅 |
Indeed. I spent the last hour thinking about this. Overriding the failure and merging is possible, but what we really want is the docker image to be tagged and pushed (once merged). So I think that before merging this PR, I need to add a commit that transforms the linter output from errors to warnings. If this is not possible, I must disable that specific linter error (as we just did for go-kit and defer close). |
|
Siiiiigh I am now facing the same errors in the GitHub API integration tests that we faced with go-kit (response payload changed). |
Rationale: majority of errchecks are fixed in go-kit. Now I am focusing on enabling the deprecations in PR #171. Re-enabling this linter is already in the ticket TODO.
So, at least this shows the error really comes from github API :) Maybe the solution is not to have this deprecated transition state, but directly remove? |
marco-m-pix4d
force-pushed
the
deprecate-apis-v0.14.0
branch
from
ec408a4 to
eedb0d5
Compare
marco-m-pix4d
force-pushed
the
deprecate-apis-v0.14.0
branch
from
eedb0d5 to
58851b3
Compare
marco-m-pix4d
force-pushed
the
deprecate-apis-v0.14.0
branch
2 times, most recently
from
1269ff7 to
acacc1d
Compare
The deprecation warnings will be picked up by the documentation shown on https://pkg.go.dev/github.com/Pix4D/cogito and by any IDE that is Go-aware. PCI-4471
This is needed to be able to, when making a tag, build and push the Docker image. This is safe since the only linter warnings are due to the deprecated APIs that we are introducing on purpose. The ticket has a TODO item to bring back the linter.
marco-m-pix4d
force-pushed
the
deprecate-apis-v0.14.0
branch
from
acacc1d to
6abeab7
Compare
3 participants
The deprecation warnings will be picked up by the documentation shown on https://pkg.go.dev/github.com/Pix4D/cogito and by any IDE that is Go-aware.
The irony is that the deprecation is detected also by the linter in CI and so CI fails :-D
PCI-4471